Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 27, 2025

Making GHA more stable.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369226 needs maintainer approval

Issue

  • JDK-8369226: GHA: Switch to MacOS 15 (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4115/head:pull/4115
$ git checkout pull/4115

Update a local copy of the PR:
$ git checkout pull/4115
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4115

View PR using the GUI difftool:
$ git pr show -t 4115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4115.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369226: GHA: Switch to MacOS 15

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3bddec8: 8352687: Opensource few JInternalFrame and JTextField tests
  • f678c66: 8352905: Open some JComboBox bugs 1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1ea8cfa6dc8e6f96fd87553331abaae17ec173ea 8369226: GHA: Switch to MacOS 15 Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting it!

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

LGTM

Gaaaaah! You jinxed it! There are compiler warnings with new compiler, so GHA does not work. I'll take a look...

@TheRealMDoerr
Copy link
Contributor

LGTM

Gaaaaah! You jinxed it! There are compiler warnings with new compiler, so GHA does not work. I'll take a look...

Hehe :-) Seems like JDK-8294594 needs to get backported, first.

@shipilev
Copy link
Member Author

shipilev commented Oct 27, 2025

Hehe :-) Seems like JDK-8294594 needs to get backported, first.

Also https://bugs.openjdk.org/browse/JDK-8294591.

That guy again, huh. Could have been backported years ago, as to not make more problems for his future self.

@shipilev
Copy link
Member Author

Working out MacOS warnings here: #4125 #4127.

@shipilev
Copy link
Member Author

shipilev commented Nov 4, 2025

Let's see if this works now...

@shipilev
Copy link
Member Author

shipilev commented Nov 4, 2025

Bleh. Also needs #3974.

@shipilev
Copy link
Member Author

shipilev commented Nov 5, 2025

Builds are working, and tests seem to be near completion, finally! I'll file the approval request.

@shipilev
Copy link
Member Author

shipilev commented Nov 5, 2025

/approval request Same reason as for other update releases: keeps GHA running even after MacOS builder deprecations.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@shipilev
8369226: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 5, 2025
@shipilev
Copy link
Member Author

shipilev commented Nov 6, 2025

Push approval granted. Here we go.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

Going to push as commit 7fe2553.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3bddec8: 8352687: Opensource few JInternalFrame and JTextField tests
  • f678c66: 8352905: Open some JComboBox bugs 1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2025
@openjdk openjdk bot closed this Nov 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@shipilev Pushed as commit 7fe2553.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants